You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#57. This 2 line fix was originally part of @tswast's PR #39 but I'm going to transfer it here so that it's easier to capture the specific fix. PR #39 also has other reliability improvements to the integration testing which resolve intermittent failures. The changes in this PR fix the consistent failure TypeError: 'NoneType' object is not iterable.
parthea
changed the title
TST: Fix broken tests failing with 'NoneType' object is not iterable
TST: Fix broken tests failing with 'NoneType' object is not iterable / module 'pandas.util.testing' has no attribute 'assertRaises'
Jun 11, 2017
My initial thought is that a release note entry isn't needed because the affected function _Dataset(<project_id>).datasets() at https://github.com/pydata/pandas-gbq/blob/master/pandas_gbq/gbq.py#L1030 is not called in gbq.py. It is only called in integration testing. A release entry is needed if we think someone may be using this specific undocumented function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57. This 2 line fix was originally part of @tswast's PR #39 but I'm going to transfer it here so that it's easier to capture the specific fix. PR #39 also has other reliability improvements to the integration testing which resolve intermittent failures. The changes in this PR fix the consistent failure
TypeError: 'NoneType' object is not iterable.